Code Smells Archives - danparkin.com

October 17, 2018

Hide Delegate

In this post, I want to talk about the refactoring Hide Delegate. I was prompted to write this by some code I reviewed around the time of writing this post where there were a number of instances of objects that were leaking their internal state. I did a post on Tell, Don’t Ask and what I saw in the code...

Code Smells/Java Comments: 0

October 14, 2018

The Single Level of Abstraction Principle (SLAP)

The Single Level of Abstraction Principle (SLAP) tells us that each method should work at a single level of abstraction, but what does that mean? The Problem Let’s look at the following code that prints the numbers 1 to 35. It’s a bit of a nonsensical example but it’ll do for the discussion that follows: class Main { public static...

Java/Refactoring/Software Design Comments: 0

September 18, 2018

The Tell Don’t Ask Principle Explained

This post will look at the principle of Tell Don’t Ask. The reason I wanted to write this was that for the longest time the naming of it confused me. I saw objects asking things of other objects all the time. However, it was a square peg round hole situation for me. It wasn’t until I learned about the Feature...

Java/Software Design Comments: 0

April 20, 2017

Helpers, Utils and Hot Spots

In my last post I talked about the danger of having classes with names that end in “helper”, “util”, “impl” in your codebase and how you should avoid them. To carry on with that topic I’ve found some, albeit loose, evidence that visualises the phenomenon and supports my claims. I came across a fantastic book called Your Code as a Crime Scene by Adam Tornhill which...

Code Smells/Refactoring Comments: 0

April 12, 2017

The Problem With Helpers, Manager and Utils

Have you ever come across a class in a project you’ve worked on with something like “helper”, “service” or “util” in the name? Unless you’re one of the fortunate few who’ve never had to regularly have a steaming hot plate of spaghetti code for your breakfast, lunch and dinner, then I’m guessing you have. Do you remember if that file...

Code Smells/Refactoring/Software Design Comments: 0

Tag: Code Smells

Hide Delegate

The Single Level of Abstraction Principle (SLAP)

The Tell Don’t Ask Principle Explained

Helpers, Utils and Hot Spots

The Problem With Helpers, Manager and Utils